Add custom playbook to deploy IPMI exporter #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are generated with: kayobe playbook run $PWD/ipmi-exporter.yml --vault-password-file ~/vaultpassword
It did not parse: e=\"/etc/prometheus/prometheus.yml\"): parsing YAML file /etc/prometheus/prometheus.yml: yaml: unmarshal errors:\n line 22: cannot unmarshal !!str `default` into []string" + sudo -E kolla_set_configs
This now seems to be in a functional state.
JohnGarbutt
reviewed
Nov 6, 2019
| @@ -0,0 +1,25 @@ | |||
| modules: | |||
| default: | |||
There was a problem hiding this comment.
Micro nit: maybe 4 spaces rather than 8?
JohnGarbutt
reviewed
Nov 6, 2019
| @@ -0,0 +1,7 @@ | |||
| --- | |||
There was a problem hiding this comment.
This is a question really... not sure about why this is here, I guess it was generated by the others scripts?
There was a problem hiding this comment.
Yep, these files were generated. We could probably move the templating here instead. Do you think that would be cleaner?
JohnGarbutt
reviewed
Nov 6, 2019
| @@ -0,0 +1,31 @@ | |||
| --- | |||
There was a problem hiding this comment.
Same as above, I guess its cool it only needs to drop into this directory, but I guess it was copied here using the above playbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is you run:
kayobe playbook run $PWD/ipmi-exporter.yml --vault-password-file ~/vaultpassword. This will generate prometheus configuration in the kayobe config directory under:$KAYOBE_CONFIG_PATH/kolla/config/prometheus. When the config changes, a handler is invoked to notify you to reconfigure prometheus. You should do so with:kayobe overcloud service reconfigure -kt prometheus --kolla-skip-tags common.This requires RSE-Cambridge/kolla-ansible#29 to merge the prometheus config.