Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lots of bugs and cleanup code in sysFeatures #637

Merged
merged 67 commits into from
Oct 14, 2024
Merged

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    aec2486 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55f64eb View commit details
    Browse the repository at this point in the history
  3. Add new bitfield manipulation functions

    field{32,64}set update a value within a bitfield. The extractBitField
    function is deprecated as it is already covered by field{32/64}.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    db216ab View commit details
    Browse the repository at this point in the history
  4. Add double-string conversion functions to sysFeatures

    Also update uint64-string conversion functions to realloc the result
    buffer passed via argument. This way one can simply call the function
    repeatedly using the same buffer without having to manually free the
    buffer.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b0ee7dd View commit details
    Browse the repository at this point in the history
  5. Fix physical unit handling in sysFeatures_intel_rapl

    Also cleanup the respective getter and setter functions to use bitfield
    functions instead of manually shifting around.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a953101 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    17d33bb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e5d6e5b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0bef1ea View commit details
    Browse the repository at this point in the history
  9. Fix DDPD test in sysFeatures

    Apparently just the wrong bit was tested previously?
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fa39181 View commit details
    Browse the repository at this point in the history
  10. Fix sysFeature intel_uncorefreq_test

    Not sure how this was ever supposed to function correctly.
    Certainly always showing an error in the debug log in case of the
    supposed success does not make any sense.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4cd613 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    91983be View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fde80ce View commit details
    Browse the repository at this point in the history
  13. Fix sysFeatures amd rapl not initializing at all

    This commit also distributes header and body code file to be more in
    line with the Intel RAPL code. AMD RAPL code is not yet checked for
    semantic bugs.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    62843fa View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    837b53d View commit details
    Browse the repository at this point in the history
  15. Sync AMD RAPL code to Intel code

    There is still a lot of redundant code for both Intel and AMD. This
    should be merged later.
    ipatix committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    701bc4e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Fix memory corruption in sysFeatures_list

    The strings were incorrectly copied when their length exceeded
    HWFEATURES_MAX_STR_LENGTH. To solve this we just use strndup, as it is
    te perfect fit for correctly copying strings at a maximum size.
    
    In addition adding a feature to an internal feature list used to ignore
    the 'tester' and 'unit' field. This would cause corruption later on.
    ipatix committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e6c4c4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e4a056 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    234c02b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    62fda1a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a2bf743 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba90420 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    558c777 View commit details
    Browse the repository at this point in the history
  8. Fix likwid_create_device for DEVICE_TYPE_CORE

    The bounds checking for valid core IDs was wrong, hence why device
    creation sometimes failed or succeeded erroneously.
    ipatix committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    98ac045 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d7fe23c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    96edd11 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a0217c6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4406ea8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    a860c88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63fe4b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8e5354 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b14fa48 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d798680 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    043d82e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    15a4d33 View commit details
    Browse the repository at this point in the history
  8. Fix warnings in sysFeatures.c

    ipatix committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    180755a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    06a92ae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dc5724f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dc844f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7fb7ce5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3339d58 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a995098 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ff52fdf View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c3c621c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    5f1bd44 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    16a23bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b040ed9 View commit details
    Browse the repository at this point in the history
  3. Cleanup more redundant code in sysFeatures

    Lots of code tends to iterate over sockets and its available threads.
    This commit rewrites the code such that is only done in one place and if
    necessary a callback function is used to test for a custom MSR
    condition.
    ipatix committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    95f0c5a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ae571df View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca4f1a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    2c4675c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e7fdcd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    816b5ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    686dacc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5b58ce5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9cec346 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3824747 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b7d4543 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    78ef390 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1766576 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2919fe8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    646dd43 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8e2850d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7958f76 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0bedd57 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    24b28fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d3878ce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b4996a6 View commit details
    Browse the repository at this point in the history