Patch for filtering #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wilson Snyder <[email protected]>
|
I'm presuming you'll use this as an example rather than merging, so not cleaning up the test failure. |
|
Main code updated & this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the -C filtering was in a different code path and didn't have the EXCLs processed. This fixes that. Most of this is just moving code to a function, which I humbly think it makes more sense, as then it reads either combined or non-combined code, then filters with common code.
Note this now would require -X to be backward compatible with the old -C, you might want to change this so that -X is the default if -C is used, then I need a new flag to turn "on" exclusion markers with -C.