Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print warnings on missing source files #53

Closed
RPGillespie6 opened this issue Jun 5, 2020 · 6 comments · Fixed by #54
Closed

Print warnings on missing source files #53

RPGillespie6 opened this issue Jun 5, 2020 · 6 comments · Fixed by #54

Comments

@RPGillespie6
Copy link
Owner

Currently fastcov does not catch file not found errors when scanning for exclusion markers.

It would provide better UX if fastcov instead printed a warning. fastcov will still exit with a non-zero return code in this case to keep backwards compatibility, but it will no longer show a stack trace.
@RPGillespie6 RPGillespie6 mentioned this issue Jun 5, 2020
Closed
RPGillespie6 added a commit that referenced this issue Jun 6, 2020
@RPGillespie6
Print files not found as errors instead of stack trace
98f39d0 
Description:
- Fix #53
- Shift exit codes to start at 3
- Add new exit code (6) for exclusion scan failure
@RPGillespie6 RPGillespie6 mentioned this issue Jun 6, 2020
Merged
RPGillespie6 added a commit that referenced this issue Jun 6, 2020
@RPGillespie6
Print files not found as errors instead of stack trace
dc41832 
Description:
- Fix #53
- Shift exit codes to start at 3
- Add new exit code (6) for exclusion scan failure
RPGillespie6 added a commit that referenced this issue Jun 6, 2020
@RPGillespie6
Print files not found as errors instead of stack trace
6d2aec3 
Description:
- Fix #53
- Shift exit codes to start at 3
- Add new exit code (6) for exclusion scan failure
@RPGillespie6
Copy link
Owner Author

RPGillespie6 commented Jun 6, 2020 •
edited
Loading

@wsnyder I think that should be the last issue you had brought up. If everything looks good, I will tag v1.7 on master

@wsnyder
Copy link
Contributor

wsnyder commented Jun 6, 2020

Yes, thanks for your help, it's in deployment.

@RPGillespie6
Copy link
Owner Author

No problem. Just curious, how long does it take fastcov to process coverage for your project (you had mentioned it took lcov ~45 minutes?)

@wsnyder
Copy link
Contributor

wsnyder commented Jun 6, 2020

With the new features it's now split between 9 fastcov joins on separate machines, each about 30 seconds. So say 4.5 minutes total, a 10x improvement. Plus I'm now doing branch coverage, so fastcov is handling more data.

@RPGillespie6
Copy link
Owner Author

RPGillespie6 commented Jun 6, 2020 •
edited
Loading

Glad to hear it. I'm fairly certain that as of now, gcov itself is the current bottleneck in terms of making coverage report generation faster. So I will have to work with the GCC folks to figure out how to speed up gcov more. Combine operations and exclusion marker scanning could probably be optimized/sped up, but I'm guessing for most people gcov itself is what takes the majority of the time.

@wsnyder
Copy link
Contributor

wsnyder commented Jun 6, 2020

FWIW the time it takes to run the compiles and tests is now 5-10x the fastcov/gcov times, so I'm pretty happy where the timing is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print files not found as errors instead of stack trace RPGillespie6/fastcov
2 participants
@wsnyder @RPGillespie6