Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite verify() #9399

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Rewrite verify() #9399

merged 3 commits into from
Dec 9, 2020

Conversation

Nekotekina
Copy link
Member

@Nekotekina Nekotekina commented Dec 9, 2020

Use automatic source location provider intrinsics.

@@ -1,4 +1,4 @@
#include "stdafx.h"
#include "stdafx.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought BOM was removed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check yourself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Utilities/ was untouched

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes

@Nekotekina
Copy link
Member Author

Did some more radical change in the end.

Expression ensure(x) returns x.
Using comma operator removed.
{
static_assert(Size < UINT32_MAX, "Array is too big for 32-bit");
return static_cast<u32>(Size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return u32{Size};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants