Remove -Wno-sign-compare #7524
Merged
Remove -Wno-sign-compare #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scary? |
Megamouse
reviewed
Feb 19, 2020
Megamouse
reviewed
Feb 19, 2020
AniLeo
reviewed
Feb 19, 2020
rpcs3/Emu/Cell/PPUAnalyser.cpp
Outdated
| @@ -719,7 +719,7 @@ void ppu_module::analyse(u32 lib_toc, u32 entry) | |||
| // Clean TOCs | |||
| for (auto&& pair : fmap) | |||
| { | |||
| if (pair.second.toc == -1) | |||
| if (pair.second.toc + 1 == 0) | |||
There was a problem hiding this comment.
weird syntax for no reason, older version is more clear
|
If signed/unsigned compares are so bad, out of the two I'd rather prefer seeing comparisons against |
Nekotekina
force-pushed
the
fixup
branch
7 times, most recently
from
6be4240
to
e2a95f2
Compare
Nekotekina
force-pushed
the
fixup
branch
3 times, most recently
from
fefe893
to
092f996
Compare
Implements operators == and != comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.