SPU LLVM: Avoid sinking stores out of non-loops #15714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
added
Optimization
elad335
force-pushed
the
analyser
branch
4 times, most recently
from
0f4cfcc
to
14bc0a1
Compare
|
Added a Linux-specific fix for GETLLAR wait. |
|
Seems slightly better on Linux. Note #15686 is reverted. Before: After: |
|
what about windows? |
Master: PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so in code not belonging to loops is non-beneficiary and may result in adverse effects on performance because the value has to be carried farther until the store.