Cleanup templates #15494
Cleanup templates #15494
Conversation
| @@ -3,6 +3,7 @@ | |||
| #include <util/types.hpp> | |||
| #include "Emu/Cell/lv2/sys_rsx.h" | |||
| #include "Emu/RSX/GCM.h" | |||
| #include "Emu/RSX/rsx_utils.h" | |||
There was a problem hiding this comment.
What are the header include additions for?
There was a problem hiding this comment.
I use the clangd extension for VS Code. Sometimes I open a file and it shows errors because includes are missing. So this is specifically for clangd, it does not matter for building.
There was a problem hiding this comment.
All this does it increase the memory footprint during builds...
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
in line 29, there is utils::address_range tile_align(const rsx::address_range& range) const; which is funny and that is why I think it requires rsx_utils.h
use utils:: namespace there instead or add a using statement in this file so it can be dropped.
The other includes seem correct
There was a problem hiding this comment.
Nah I will merge and fix later.
| @@ -1,5 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include "Emu/RSX/GL/GLTexture.h" | |||
I was learning C++ templates and made these changes. It does not improve anything but makes the code a bit shorter.