HLE: clear lower bits of Free Disk Space value #15313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSuih
reviewed
Mar 12, 2024
| @@ -421,7 +421,7 @@ error_code cellHddGameCheck(ppu_thread& ppu, u32 version, vm::cptr<char> dirName | |||
| // 40 GB - 1 kilobyte. The reasoning is that many games take this number and multiply it by 1024, to get the amount of bytes. With 40GB exactly, | |||
| // this will result in an overflow, and the size would be 0, preventing the game from running. By reducing 1 kilobyte, we make sure that even | |||
| // after said overflow, the number would still be high enough to contain the game's data. | |||
| get->hddFreeSizeKB = 40 * 1024 * 1024 - 1; | |||
| get->hddFreeSizeKB = 40 * 1024 * 1024 - 256; | |||
There was a problem hiding this comment.
The comment above should be updated. Also would be nice if this same copy paste could be merged into one variable/function.
AniLeo
approved these changes
Mar 13, 2024
|
The comment is wrong |
|
NANI. Nevermind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix the loading of Fuel Overdose Demo.