Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities: Add support for portable user directory. #15064

Merged
merged 3 commits into from Jan 20, 2024
Merged

Utilities: Add support for portable user directory. #15064

merged 3 commits into from Jan 20, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2024

No description provided.

@elad335
Copy link
Contributor

elad335 commented Jan 19, 2024

I thought this is what $(EmulatorDir) token in VFS is for?

@elad335
Copy link
Contributor

elad335 commented Jan 19, 2024

So if it's not for game data (VFS), but caches and configs. Why would you want it to be portable by default? Say a user removes a copy of RPCS3 from one place then downloads it again to another, custom configs and caches are no longer. So make it optional I think, we may need to add support for it to be non-portable for Windows actually.

@Megamouse
Copy link
Contributor

The whole folder is by design portable, so why add a portable dir into a portable folder?

@elad335
Copy link
Contributor

elad335 commented Jan 19, 2024

I see, thanks for the addition, we may need to update or guidelines on the website.

Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
@elad335 elad335 merged commit 9c354ee into RPCS3:master Jan 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants