[Bugfix] sys_fs: Fixed sys_fs_unlink()'s failing to delete files in dev_usbXXX & Misc syscall implementation fixups #14939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian218
changed the title
Megamouse
reviewed
Jan 1, 2024
Megamouse
approved these changes
Jan 2, 2024
sys_fs: Fixed get_mp() up for dev_usbXXX
|
Visual remarks of the sys_ss_update_manager data correction added last week: Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys_fs_unlink() used to fail to delete files in dev_usbXXX because it used
mp->root, which is always "dev_usb" for all dev_usbXXX devices, as argumentdev_rootpassed tovfs::host::unlink()for further processing.This PR fixed the bug mentioned above.