Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellSaveData: Fix check 58, implement checks 77 and 76 #14443

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Aug 7, 2023

Turns out parental_level is only checked once for being higher than 11 and then the used register is recycled for a different purpose. I searched the entire disassembly for another load from this member and could not find any. This likely was a reverse-engineering mistake caused by looking at the following check, because before #6206 there was an array check there instead. I also implemeneted the following listParam checks.

Fixes #14245

@elad335 elad335 force-pushed the spu-log branch 3 times, most recently from ba6c2d1 to 4b78299 Compare August 7, 2023 14:24
@elad335
Copy link
Contributor Author

elad335 commented Aug 7, 2023

PPU-c1be5dc25994c9b4006295882516c829f8c63707:
  "Graphics Fix":
    Games:
      "SONIC THE HEDGEHOG":
        BLJM60006: [ 01.01 ]
    Author: "elad335"
    Notes: "Fixes missing graphics ingame."
    Patch Version: 1.0
    Patch:
    - [ calloc, 0x00f06c64, 0x4 ]
    - [ be32, 0x00000000, 0x38800003 ] # li r4, 3
    - [ jumpf, 0x00000000, "RPCS3_HLE_LIBRARY:WaitForSPUsToEmptySNRs" ] # Args: (SPU ID, 3)
    - [ be32, 0x00000000, 0x38800000 ] # li r4, 0
    - [ be32, 0x00000000, 0x44000002 ] # sc

BLJM60006 patch version.

@elad335 elad335 merged commit edf4f7e into RPCS3:master Aug 7, 2023
5 checks passed
@elad335 elad335 added Bugfix Savedata Anything that involves cellSaveData LLVM Related to LLVM instruction decoders labels Aug 7, 2023
@RPCS3 RPCS3 deleted a comment from MasterChief747 Aug 5, 2024
@RPCS3 RPCS3 locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bugfix LLVM Related to LLVM instruction decoders Savedata Anything that involves cellSaveData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BLJM60006] Sonic The Hedgehog - Doesn't create save data making it impossible to get past title screen
1 participant