Make experimental build warning modal #14431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that prevents unofficial builds from working correctly (at least on macOS) since the switch to Qt 6.
Specifically, the game window does not open (but the game still runs in the background and audio can be heard), and right clicking on the log window does not show the context menu even though the cursor changes.
Setting the warning window to "modal" (as it seemingly was before switching to Qt 6) fixes this.
Changes this:
To this:
I'm not sure if the cause is a Qt bug, or just the way Qt handles non-modal windows with no parent on macOS.