rsx: Reimplement projected texturing to play nice with the subimage views

[kd-11]

#14142

Testing needed:

• Resident Evil: Code Veronica X
• TLOU
• Uncharted 2 & 3

[Linear524]

Hi KD-11 !
I tried this PR and unfortunately RPCS3 crashes when trying to load main menu :(
Logs shows this:
E RSX: ERROR: 0:633: 'coord' : undeclared identifier
ERROR: 0:633: 'xyz' : vector swizzle selection out of range
ERROR: 0:633: 'w' : vector swizzle selection out of range
ERROR: 0:633: '[]' : scalar integer expression required
ERROR: 0:633: '_texcoord_xform' : no matching overloaded function found
ERROR: 0:633: 'texture' : no matching overloaded function found
ERROR: 0:633: '' : compilation terminated
ERROR: 7 compilation errors. No code generated.

E RSX:
F {RSX Worker 2} SIG: Thread terminated due to fatal error: Failed to compile fragment shader
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\VKProgramPipeline.cpp:29[:25], in function compile)
E RSX: ERROR: 0:632: 'coord' : undeclared identifier
ERROR: 0:632: 'xyz' : vector swizzle selection out of range
ERROR: 0:632: 'w' : vector swizzle selection out of range
ERROR: 0:632: '[]' : scalar integer expression required
ERROR: 0:632: '_texcoord_xform' : no matching overloaded function found
ERROR: 0:632: 'texture' : no matching overloaded function found
ERROR: 0:632: '' : compilation terminated
ERROR: 7 compilation errors. No code generated.

E RSX:
F {RSX Worker 10} SIG: Thread terminated due to fatal error: Failed to compile fragment shader
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\VKProgramPipeline.cpp:29[:25], in function compile)
E RSX: ERROR: 0:634: 'coord' : undeclared identifier
ERROR: 0:634: 'xyz' : vector swizzle selection out of range
ERROR: 0:634: 'w' : vector swizzle selection out of range
ERROR: 0:634: '[]' : scalar integer expression required
ERROR: 0:634: '_texcoord_xform' : no matching overloaded function found
ERROR: 0:634: 'texture' : no matching overloaded function found
ERROR: 0:634: '' : compilation terminated
ERROR: 7 compilation errors. No code generated.

E RSX:
F {RSX Worker 1} SIG: Thread terminated due to fatal error: Failed to compile fragment shader
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\VKProgramPipeline.cpp:29[:25], in function compile)

[kd-11]

@Linear524 Retest

[solarmystic]

Still getting the same fatal error and rpcs3 crash after booting up TLOU using the latest PR build unfortunately.

F {RSX [0x008590c]} SIG: Thread terminated due to fatal error: Failed to compile fragment shader (in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\VKProgramPipeline.cpp:29[:25], in function compile)

Logfile:-
RPCS3.log

[kd-11]

@davewuk Thanks. The PR breaks some things from reports on discord, I'll update when the found issues are fixed.

[readywer]

GT5 with this pr.

[solarmystic]

TLOU dynamic shadow fixed as of the latest pr commit on my end.

[kd-11]

Try with an older build from like a month ago and see if the problem is fixed there with the same settings.

[kd-11]

@davewuk Is there anything that worked better (with regards to shadows) on the older build? Verify without using any upscaling. If this PR produces correct results, we can proceed with the merge.

[kd-11]

Thanks for confirming. I'll proceed and merge this work then.

[Linear524]

Uncharted series (2 and 3) was always partially broken. As well as TLoU post processing effects and SPU MLAA.
But anyway - I suggest to never use scaling and use FSR upscaling instead... With native 720p. This is the only way to see all intended graphical effects without those "skipping patches"... Just try to set WCB+RCB+WDB+RDB without MLAA skipping patch and watch the result...

[Linear524]

Without WCB+RCB+WDB+RDB and without working MLAA you will miss:

• Color Balance and Dynamic Exposure effects
• DoF effects
• Bloom control
• Morphological Antialiasing
• Proper explosion FXs
• Vignette effects
• Film Grain effect
• Proper reflections on cubemaps
• etc

[Linear524]

@davewuk

• I don't have to, because I saw this for years and you can try it by yourself

[kd-11]

Don't add discussion comments to closed PRs.