Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only silence logging during gameplay #14143

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

Megamouse
Copy link
Contributor

Turns out disabling the log at all times is a bit counter productive.

@elad335
Copy link
Contributor

elad335 commented Jul 7, 2023

It may be a good idea to manage it through FXO:

struct logs_reenable_t
{
	logs_reenable_t() =  default:

	logs_reenable_t(const logs_reenable_t&) = delete;

	logs_reenable_t& operator =(const logs_reenable_t&) = delete;

	~logs_reenable_t() noexcept
	{
		// Enable logging
		rpcs3::utils::configure_logs(true);
		g_fxo->get<logs_reenable_t>(); // Register destructor 
	}
};

@Megamouse
Copy link
Contributor Author

No. It should start logging before anything is destroyed

@Megamouse Megamouse merged commit 4aec48c into RPCS3:master Jul 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants