Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_fs: Updated some fs-related code following up #14086 #14088

Merged
merged 2 commits into from
Jun 25, 2023
Merged

sys_fs: Updated some fs-related code following up #14086 #14088

merged 2 commits into from
Jun 25, 2023

Conversation

brian218
Copy link
Contributor

I implemented fs::get_normalized_path() and accordingly updated some sys_fs code as per the conclusion suggested by @Nekotekina and @elad335 in #14086.

@elad335
Copy link
Contributor

elad335 commented Jun 24, 2023

Maybe just make it just a sys_fs static function for now, it's already shown that this implementation does not work for some unicode characters in some locales. We have different alternatives elsewhere like Emu.GetCallbacks().resolve_path that are based on host filesystem path arguments.

@brian218
Copy link
Contributor Author

Maybe just make it just a sys_fs static function for now, it's already shown that this implementation does not work for some unicode characters in some locales. We have different alternatives elsewhere like Emu.GetCallbacks().resolve_path.

I'll move it to lv2_fs_object.
But as for Emu.GetCallbacks().resolve_path, I remember I tried that too before I adopted the std::filesystem method, and it didn't seem to work for virtual paths (paths that are unrelated to the host file system).

@Nekotekina
Copy link
Member

maybe u8path should be used?

@brian218 brian218 requested a review from elad335 June 25, 2023 03:45
@brian218
Copy link
Contributor Author

MLB the show 16 faces edited after version 0.28 15157 come out with defect

#14081 (comment)
#14088 (comment)
0.0.28-15157 is #13986, so DO NOT CASUALLY SPAM UNRELATED ISSUES IN UNRELATED PRs.

@RPCS3 RPCS3 locked and limited conversation to collaborators Jun 26, 2023
@RPCS3 RPCS3 deleted a comment from dari1991 Jun 26, 2023
@RPCS3 RPCS3 deleted a comment from dari1991 Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants