Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Interface: Game searching improvements #13719

Merged
merged 3 commits into from
Apr 22, 2023
Merged

User Interface: Game searching improvements #13719

merged 3 commits into from
Apr 22, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Apr 21, 2023 •
edited
Loading

  • Focus to game searchbar on load.
  • Make return key press focus to game list's first entry if game searchbar is focused.
  • Ignore trademarks, hyphen, colons and duplicated spaces when searching games. (fallback when otherwise no search results would have not been yielded):
    This means you can now search easily for game titles such as "Spider-Man: Web of Shadows" or "Killzone®3 Demo".
  • Make Ctrl+F focus to game search bar.

This pull request makes it easily doable to launch any game even from large game lists without lifting the hands from keyboard within no time!

@Megamouse Megamouse added the GUI label Apr 21, 2023
@elad335 elad335 force-pushed the disc-io branch 3 times, most recently from 0e4a19e to 01dfa22 Compare April 21, 2023 16:39
@elad335 elad335 marked this pull request as draft April 21, 2023 16:58
@elad335
Copy link
Contributor Author

elad335 commented Apr 21, 2023

  • Ignore trademark when searching games.

@elad335 elad335 changed the title User Interface: Focus to game searchbar on load User Interface: Game searching improvements Apr 21, 2023
@elad335 elad335 force-pushed the disc-io branch 5 times, most recently from 8fa22d5 to 0f4da5c Compare April 21, 2023 17:59
@elad335 elad335 requested a review from Megamouse April 21, 2023 17:59
@elad335 elad335 marked this pull request as ready for review April 21, 2023 17:59
@elad335 elad335 force-pushed the disc-io branch 3 times, most recently from e107091 to d188a1d Compare April 21, 2023 18:13
@elad335 elad335 requested a review from Megamouse April 21, 2023 18:15
@elad335 elad335 force-pushed the disc-io branch 2 times, most recently from d2445bf to ac13ad6 Compare April 22, 2023 08:27
@elad335 elad335 force-pushed the disc-io branch 3 times, most recently from 180e0c9 to d1b3440 Compare April 22, 2023 10:06
@elad335 elad335 requested a review from Megamouse April 22, 2023 10:27
@elad335 elad335 force-pushed the disc-io branch 3 times, most recently from 0d9eee2 to d2a8856 Compare April 22, 2023 12:03
@elad335 elad335 requested a review from Megamouse April 22, 2023 12:19
@Megamouse
Copy link
Contributor

As with all other features, you forgot to add Ctrl+F to the grid xD

Megamouse
Megamouse reviewed Apr 22, 2023
View reviewed changes
rpcs3/rpcs3qt/game_list.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list.cpp Show resolved Hide resolved
@elad335
UI: Focus to game searchbar on load
062889d 
Make return key press focus to game list's first entry.
@elad335
UI: Ignore trademark as a fallback when searching games
cd244bc 
Also colons and hyphen.
@Megamouse Megamouse merged commit 6bf7716 into RPCS3:master Apr 22, 2023
@elad335 elad335 deleted the disc-io branch April 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkhost1999 Darkhost1999 Darkhost1999 left review comments

@Megamouse Megamouse Megamouse approved these changes

Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad335 @Megamouse @Darkhost1999