-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPU LLVM: experimental change #13710
Conversation
RPCS3 crashes when building a SPU cache on this PR Build. |
Can I get more results from different games? |
It crashes on every games that I've tested, including Demon's Souls. Edit: Oh wait, it doesn't crash on the game called "The Wolf Among Us" |
Assassin's Creed [NPUB30451].log |
So basically the results are: Midnight Club: LA Demon's Souls The Wolf Among Us God of War III God of War: Asension Need for Speed: The Run Battlefield 3 InFamous Red Dead Redemption |
I see, please retest |
Sorry if this is a dumb question, but are you creating this PR just to improve the stability or the performance? |
RPCS3.log.gz |
@Ordinary205 basically performance |
This comment was marked as outdated.
This comment was marked as outdated.
This change positively effects Netflix's first boot with a brand new SPU cache. Bringing the ability to get to the login to your profile screen considerably faster than ever before. 😁 |
I mean, if this PR improved your float performance this much over master then we can pack it up cause RPCS3 is done. That much of an increase is almost like going from a core 2 duo to a ryzen 3700X, those results aren't correct. |
I copied and pasted. But I'll run the test a couple of times on master more than just 1st boot and replace the master test results |
I think it's just a LLVM16 PR regression that is fixed. |
Back again with the usual 5 game (P5, DeS, TLOU, GOWA, GOW3) round up. All 5 games booted and ran fine. Performance is within margin of error for all games tested compared to master so I felt that individual break downs were unnecessary. Captured SS with results for those who're interested:- |
@solarmystic does that count as a performance regression when god of war III has lower 1% FPS than master? |
Retested again with latest pr commit (9e75cb9) versus latest master (14896). GOW 3 - Minor gain on average FPS, minor reduction in 1% FPS. GOWA - Within margin of error for average FPS, minor gain in 1% and 0.1% FPS. The Last of Us - Identical average FPS, minor gain in 0.1% FPS Persona 5 - Within margin of error for all metrics. Demon's Souls - Within margin of error on average, slight reduction in 1% FPS. SS with all results:- |
Please test.