Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_fs & VFS: Misc bug fixes #13477

Merged
merged 3 commits into from
Apr 5, 2023
Merged

sys_fs & VFS: Misc bug fixes #13477

merged 3 commits into from
Apr 5, 2023

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Mar 2, 2023

  1. Do not mount dev_usbXXX if its path is not properly specified since this can cause confusion to some games that detect and determine which USB flash drive to use.
  2. Allow dev_usbXXX to be mounted, unmounted, and formatted(newfs) by the corresponding sys_fs syscalls as some games do format the attached USB flash drives in some cases.
  3. Improve the permission check for the three syscalls mentioned above: PS3 root permission is required in order to perform actions on devices other than dev_usbXXX.
  4. Add read-only flag check to sys_fs_newfs() to prevent devices with this flag from being formatted.
  5. Implement CELL_FS_PATH path-as-device support.

@brian218 brian218 marked this pull request as draft March 3, 2023 10:08
@brian218 brian218 marked this pull request as ready for review March 3, 2023 13:27
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
@brian218 brian218 marked this pull request as draft March 5, 2023 02:59
@brian218 brian218 marked this pull request as ready for review March 5, 2023 15:32
@brian218 brian218 requested a review from elad335 March 6, 2023 14:55
Copy link
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather not adding new lv2_obj::sleep calls, I know it's like other syscalls, but its placemrnt is questinable in many places.

@brian218
Copy link
Contributor Author

brian218 commented Mar 6, 2023

I rather not adding new lv2_obj::sleep calls, I know it's like other syscalls, but its placemrnt is questinable in many places.

How about ppu.state += cpu_flag::wait?

@elad335
Copy link
Contributor

elad335 commented Mar 6, 2023

That statement is okay.

@brian218 brian218 requested review from elad335 and Megamouse and removed request for elad335 March 6, 2023 16:10
@brian218 brian218 requested a review from Megamouse March 17, 2023 15:30
@brian218 brian218 requested a review from Megamouse March 18, 2023 02:16
@brian218 brian218 requested review from elad335 and Megamouse and removed request for Megamouse March 26, 2023 12:35
@Megamouse Megamouse merged commit 8a509af into RPCS3:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants