Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx/overlays: Misc Improvements #13355

Merged
merged 6 commits into from
Feb 4, 2023
Merged

rsx/overlays: Misc Improvements #13355

merged 6 commits into from
Feb 4, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Feb 4, 2023

  • Unify overlay rendering shaders to reduce the headache of maintaining 2 separate paths
  • Add support for disabling vertex snap on the overlays. This fixes rendering the round parts of rounded rectangles.
  • Fix grid snap code which was broken for years due to a misplaced bracket 🙈
  • Force disable the rounded rectangles feature on mac OS which doesn't support triangle fans. A workaround will be provided at a later time.

@Megamouse
Copy link
Contributor

hmm maybe also add a comment. otherwise noone knows why it's ifdefed

@kd-11
Copy link
Contributor Author

kd-11 commented Feb 4, 2023

hmm maybe also add a comment. otherwise noone knows why it's ifdefed

I think the __APPLE__ part says it all 😆
It's temporary anyway, I'll get to it when I can build macos without tearing my hair out.

@Megamouse
Copy link
Contributor

maybe show comparisons. too lazy to take a look lmao

@kd-11
Copy link
Contributor Author

kd-11 commented Feb 4, 2023

After:
image

@kd-11 kd-11 merged commit 508dd2b into RPCS3:master Feb 4, 2023
@kd-11 kd-11 deleted the message-queue branch August 9, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants