CLI: add option to boot rsx capture #13330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
RSX
CLI
|
Why not include it in game boot? This is also how savestates work. |
|
Because there's already a dedicated boot function. Why should I clutter the game boot then? |
|
You can call the dedicated function inside Emulator::Load, it just a few lines. It simplies booting as there is no requirement in using a custom command. |
|
It complicates the loading and it doesn't even fit any of the nomenclature, logging, etc. There's no reason to stuff the logic into the regular load mechanism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples:
.\rpcs3.exe --rsx-capture "C:\mypath\capture.rrc"
.\rpcs3.exe --no-gui --rsx-capture "C:\mypath\capture.rrc"
.\rpcs3.exe --headless --rsx-capture "C:\mypath\capture.rrc"