Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB: Added VFS USB mass storage devices to the USB device list #13214

Merged
merged 4 commits into from
Jan 18, 2023
Merged

USB: Added VFS USB mass storage devices to the USB device list #13214

merged 4 commits into from
Jan 18, 2023

Conversation

brian218
Copy link
Contributor

  1. Implemented control_transfer(0x80), which is used to retrieve the descriptor of a USB device.
  2. Added VFS USB mass storage devices to the USB device list.

A number of System 357 games (e.g. Tekken and Razing Storm) retrieve the VID/PID/Serial Number information of a USB mass storage device via control_transfer(0x80) instead of sys_fs_fcntl(0xc000001c).

This PR makes those games pass the USB dongle check as long as proper USB information is set.

@brian218
Copy link
Contributor Author

brian218 commented Jan 12, 2023

I've implemented all of the Device-to-Host USB Standard Device Requests (0x80) for emulated USB devices.

rpcs3/Emu/Io/usb_device.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Io/usb_device.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Io/usb_device.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Io/usb_device.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
@Megamouse Megamouse removed their request for review January 13, 2023 16:41
Utilities/Config.h Outdated Show resolved Hide resolved
Utilities/Config.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_fs.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/lv2/sys_usbd.cpp Outdated Show resolved Hide resolved
@Megamouse Megamouse removed their request for review January 16, 2023 12:19
@Megamouse
Copy link
Contributor

Please stop requesting reviews from me ;)
I've removed myself as reviewer 3 times now for a reason.

@Megamouse Megamouse removed their request for review January 16, 2023 15:52
@Megamouse
Copy link
Contributor

Reason 1: We all have jobs and RL etc., so you just gotta wait until someone has time or takes interest.
Reason 2: You keep changing stuff daily (be it due to reviews or not), so people have to check it again after each change.
Reason 3: I'm not the expert in usb stuff, so I won't merge it anyway before I got some second opinion.

@RipleyTom
Copy link
Contributor

You do not need to update your branch, as long as there is no conflict it'll be rebased automatically before getting merged.

Copy link
Contributor

@RipleyTom RipleyTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that lgtm

rpcs3/Emu/Io/usb_device.cpp Outdated Show resolved Hide resolved
@Megamouse Megamouse merged commit c3c2bb7 into RPCS3:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants