Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Improve surface<->texture cache communication #13077

Merged
merged 7 commits into from
Dec 17, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 15, 2022

Currently only tracks protection setting which is important for validating orphaned slices.
While we're at it, let's also use it to speed up redundant flush operations.

Fixes #12971

@Darkhost1999
Copy link
Contributor

F {RSX [0x0b08048]} SIG: Thread terminated due to fatal error: Verification failed
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\Common\surface_utils.h:732[:4], in function has_flushable_data)
RPCS3.zip
Far Cry 3 lasted maybe 5 seconds in game

@Megamouse Megamouse added the RSX label Dec 15, 2022
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 15, 2022

@Darkhost1999 Should be fixed now. Please verify.

@Darkhost1999
Copy link
Contributor

F {RSX [0x002c2ac]} SIG: Thread terminated due to fatal error: Verification failed
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\Common\surface_utils.h:756[:4], in function has_flushable_data)
RPCS3.log
Game froze first test so I removed Read buffers and WDB the game doesn't need and tested with accurate rsx reservation access instead of accurate gettlar.

Here is with WCB only. Bare minimum settings required to play this game.
F {RSX [0x002ba9c]} SIG: Thread terminated due to fatal error: Verification failed
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\Common\surface_utils.h:756[:4], in function has_flushable_data)
RPCS3.log
I have to force the task to close

@kd-11 kd-11 marked this pull request as draft December 15, 2022 22:04
- Beware of clone operations. Blindly inheriting the parent's metadata is wrong.
- It is possible, especially when reusing a pre-existing slice, that the parent and child info has diverged
@kd-11 kd-11 marked this pull request as ready for review December 17, 2022 11:38
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 17, 2022

@Darkhost1999 You can try again now

@Darkhost1999
Copy link
Contributor

Appears to be working as expected and intended. Just drove around and teleported a few places to double check different zones and regions.
Was just testing #10998 with no change observed. Thanks for the fixes.

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Dec 17, 2022

As for testing WCB and frame times what better game to test than WCB's arch nemesis
Master
0 0 25-14479 _ Need for Speed Most Wanted  BLUS31010
PR
Pull_13077 _ Need for Speed Most Wanted  BLUS31010
For spectators: focus more on the averages and 1% values. I also notice some graphical changes. All good changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] WCB causes inconsistent frametimes for MGS4 (#12746)
3 participants