sys_fs: Integrated the function of get_vfs() into get_mp() to avoid unnecessary iteration #13030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pass mp as argument to get_vfs and you can drop most of your changes |
But the mp of g_mp_sys_dev_usb doesn't discriminate dev_usbXXX. |
Megamouse
reviewed
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that get_vfs(), which calls get_mp() inside to determine the mount point, is usually called along with get_mp(), I integrated the function of get_vfs() into get_mp() so as to avoid unnecessary iteration.
get_mp("/device_path")still works as usual, and in case you need the associated vfs path as well, simply pass a pointer to a string to it likeget_mp("/device_path", &a_string).