Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error_code, make HDD1 errors be warnings #12983

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Nov 26, 2022

  • Allow setting error as warning level so HDD1 errors would be logged as warnings.

Implements #12667

@Nekotekina
Copy link
Member

I would like to not add new thread_local variable. I think it should be solved similarly to not_an_error: possibly a constructor with additional argument which transforms error_code report into a warning or something.

@elad335
Copy link
Contributor Author

elad335 commented Nov 26, 2022

Hmm, I'll remove the method to manually set it. But I want to prevent multiple reports in the same syscall and the ability to silence errors that should be ignored. (so wrapping methods in CellError instead of error_code for example can be avoided)

@elad335 elad335 force-pushed the error-report branch 3 times, most recently from 267cd4e to 096becf Compare November 26, 2022 11:17
@Nekotekina
Copy link
Member

I'd suggest passing a reference to logs::message to make_report.
This would allow to choose both channel and severity:
return {sys_fs.warning, CELL_ENOENT, path};

@elad335 elad335 force-pushed the error-report branch 2 times, most recently from 10a34a6 to eb77974 Compare November 26, 2022 12:06
@elad335 elad335 requested review from Nekotekina and removed request for Nekotekina November 26, 2022 12:08
@Nekotekina
Copy link
Member

Where do you encounter double reports? It's usually easily avoidable, but moving report to GPR binding:

  1. Creates a chance of missing report in certain cases (sub-calls) where it could be desirable.
  2. Slower function exit for errorless case

@elad335
Copy link
Contributor Author

elad335 commented Nov 26, 2022

Removed for now.

@Nekotekina Nekotekina merged commit 8b934ab into RPCS3:master Nov 26, 2022
@elad335 elad335 deleted the error-report branch November 26, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants