Add RPCS3/games/ for automatic games detection, support PSN games outside HDD0 #12982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Nov 26, 2022
•
elad335
commented
- Create a directory called "games" in RPCS3 program directory which disc games can be put and automatically be added to the games list.
- Support PSN games outside of /dev_hdd0/game. Technically RPCS3 never forbid it, it just crashed most of the time when attempting to load them. Updates are not installed for it. (meaning it can be used as a backup in case updating fails)
- Do not load PARAM.SFO with TITLE_ID that has non-alphabetic or non-digits characters, this is to protect from potential malware files with special filesystem redirections.
elad335
changed the title
elad335
force-pushed
the
games-gui
branch
5 times, most recently
from
7859fb4
to
acebbe6
Compare
Megamouse
reviewed
Nov 27, 2022
Comment on lines
+973
to
+986
| constexpr auto game0_path = "/dev_hdd0/game/"sv; | ||
|
|
||
| if (argv[0].starts_with(game0_path) && !fs::is_file(vfs::get(argv[0]))) | ||
| { | ||
| std::string title_id = argv[0].substr(game0_path.size()); | ||
| title_id = title_id.substr(0, title_id.find_last_not_of('/')); | ||
|
|
||
| // Try to load game directory from list if available | ||
| if (auto node = (title_id.empty() ? YAML::Node{} : games[title_id])) | ||
| { | ||
| disc = node.Scalar(); | ||
| m_path = disc + argv[0].substr(game0_path.size() + title_id.size()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Tries to find the digital game in games.yml
There was a problem hiding this comment.
This is for savestates, savestates save only guest path so it needs to deal with it by trying to find the game in places it can be. (that's how disc games are handled as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.