logs improvements #12944
Merged
logs improvements #12944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Nov 12, 2022
•
elad335
commented
- Do not use unsafe pointer arithmetics exceeding existing memory. (exceeding m_fptr)
- Properly use the entire 32MB of the buffer, previously only 16MB were used for concurrent access.
- Fix a bug occurring after attempting to push 1TB (40 bits).
- Flush the log before hitting a debugging breakpoint.
elad335
force-pushed
the
patch-6
branch
7 times, most recently
from
1ec3a23
to
f268ac9
Compare
Megamouse
reviewed
Nov 12, 2022
* Do not use unsafe pointer arithmetics exceeding existing memory. (exceeding m_fptr) * Properly use the enire 32MB of the buffer, previously only 16MB were used for cuncurrent access. * Fix a bug occurring after attempting to push 1TB (40 bits). * Flush the log before hitting a debugging breakpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.