Replace .at() calls with custom method showing actual source location on failure #12684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Sep 19, 2022
rpcs3/util/types.hpp
Outdated
| @@ -1056,6 +1056,41 @@ template <typename T, usz Size> | |||
| return static_cast<u32>(Size); | |||
| } | |||
|
|
|||
| template <typename T, usz Size, typename U> | |||
| [[nodiscard]] constexpr auto& at32(const T (&array)[Size], u32 index, | |||
There was a problem hiding this comment.
I mean this overload is better removed in this widely used header, and std::size can help with that. A global concept can be written as std::as_const(x)[0].
There was a problem hiding this comment.
Okay, I'll look into it
Nekotekina
force-pushed
the
master
branch
5 times, most recently
from
5840eb4
to
a66cdb9
Compare
Nekotekina
changed the title
Nekotekina
requested review from
elad335,
Megamouse and
kd-11
and removed request for
elad335
elad335
reviewed
Sep 20, 2022
| { | ||
| broadcast_insert(range); | ||
| m_data[block_for(range.start)].insert_or_assign(range.start, std::forward<T>(value)); | ||
| } | ||
|
|
||
| inline iterator find(const u32 key) |
There was a problem hiding this comment.
Seems like the methods find and at have been swapped unintendedly.
There was a problem hiding this comment.
I removed at and added count to make it compatible with at32 requirements
|
I'd rather have these data types wrapped or something instead of replacing all the calls with some obscure syntax |
kd-11
reviewed
Sep 21, 2022
Works like .at() but uses source location for "exception".
|
I think an alternative (replacing container types) would be too intrusive and not always possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a supplement for common STL .at() methods but which also provides source location.