IdManager.cpp: Fix cellFs IDs #12604
Conversation
|
Added this as an ID trait. |
| Emu.GetCallbacks().enable_disc_eject(true); | ||
| Emu.GetCallbacks().enable_disc_insert(false); | ||
| Emu.GetCallbacks().enable_disc_eject(!!func_eject); | ||
| Emu.GetCallbacks().enable_disc_insert(!!func_insert); |
There was a problem hiding this comment.
I think the eject enabling had the same bug if there is no disc.
There was a problem hiding this comment.
The whole thing is only supposed to work if the game is a disc game.
So it is guaranteed that a disc is present when the callback is registered.
The game would've been terminated if it was ejected beforehand.
So it has to eject the disc before it can insert a new one
There was a problem hiding this comment.
The only way to enable this for HDD games would be to check here if bdvd is mounted and then enable one of them depending on the mounting state and the presence of the respective callback.
There was a problem hiding this comment.
In any case it is wrong to enable both eject and insert.
There was a problem hiding this comment.
Additionally, insert should not be enabled on an eject if the insert callback is missing and vice versa
|
Please stop adding random stuff to PRs with unrelated titles |
Fix cellFs IDs to always take the lowest ID value possible, this fixes this game's installation: tries to access the ID of a closed installation file after opening different ones after. It works on PS3 because the old ID should be equal to one of the newer ones.
I've limited this fix very specifically to cellFs because I really do not want regressions.. Testcase which now matches RPCS3: elad335/myps3tests@51b1257
Remove wrong error checking in cellGame - this allows for games to register only the disc-eject callback as seen in this game.
Fixes Spider-Man: Web of Shadows, Intro -> Ingame. (if you already ran this game on RPCS3 you need to delete its installation data for it to work)
