Debugger Improvements #12444
Merged
Debugger Improvements #12444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Aug 2, 2022
•
elad335
commented
- Fix the selection of instructions and all the connected functionality of it - it was hilariously broken.
- Use "third-centered" PC by default on the debugger instead of back PC - we want to view previous instructions, just not as many as future instructions.
- Fix memory leak in RSX debugger.
- Name VP vertex arrays.
- Minor race fix in sys_spu_thread_receive_eventt.
elad335
force-pushed
the
debugger
branch
2 times, most recently
from
702407b
to
9942ce3
Compare
Megamouse
reviewed
Aug 5, 2022
elad335
force-pushed
the
debugger
branch
4 times, most recently
from
d0420c4
to
732e83e
Compare
* Fix instruction-selection dependent functionality. * Remove odd instruction position jumps in add/remove breakpoint. * Make PC fixate at 1/3 of the frame because knowing future instructions is more important than knowing the previous.
Check final cpu_state::state value for suspend state because that's the variable the thread waits on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.