Overlays: smash some bugs in message dialogs #12396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
approved these changes
Jul 26, 2022
Megamouse
force-pushed
the
overlays
branch
2 times, most recently
from
d555beb
to
552787b
Compare
- Fix off by one issue when we wrapping a line caused by unnecessary zeroed whitespaces. - Fix centering of lines that end with carriage return caused by overzealous reset of counters. - Remove fabs where there shouldn't be any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old positioning was completely wrong in certain cases. How did I miss that?
I'll just show the good versions. On master these are all off-center or aligned to the left (apart from the first one, which works).