-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating ROCm whl upon release #259
Changes from all commits
b128ce9
110cb22
0cf10db
8b33f50
6c17fb6
fba7cca
993ffeb
3103abb
0f820f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
#!/bin/bash | ||
set -eux | ||
|
||
python_executable=python$1 | ||
cuda_home=/usr/local/cuda-$2 | ||
python_executable=python3 | ||
|
||
# Update paths | ||
PATH=${cuda_home}/bin:$PATH | ||
LD_LIBRARY_PATH=${cuda_home}/lib64:$LD_LIBRARY_PATH | ||
|
||
# Install requirements | ||
$python_executable -m pip install -r requirements-build.txt -r requirements-cuda.txt | ||
$python_executable -m pip install -r requirements-rocm.txt | ||
|
||
# Limit the number of parallel jobs to avoid OOM | ||
export MAX_JOBS=1 | ||
# Make sure release wheels are built for the following architectures | ||
export TORCH_CUDA_ARCH_LIST="7.0 7.5 8.0 8.6 8.9 9.0+PTX" | ||
export VLLM_FA_CMAKE_GPU_ARCHES="80-real;90-real" | ||
export PYTORCH_ROCM_ARCH="gfx90a;gfx942" | ||
|
||
rm -f $(which sccache) | ||
|
||
bash tools/check_repo.sh | ||
export MAX_JOBS=32 | ||
|
||
# Build | ||
$python_executable setup.py bdist_wheel --dist-dir=dist | ||
cd gradlib | ||
$python_executable setup.py bdist_wheel --dist-dir=dist | ||
cd .. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes it perfect, doesn't it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll see if whls will get published this time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was the last time I approved without seeing functionality proof. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely "python_executable=python$1" is a cryptic way to interface the desirable python flavor (not ideal), but why we limit the script to python3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other options are there in our ROCm release docker (or anywhere)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python2 ? If somebody decides to use python2 at some point (for whatever reason) this code will break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code will not be within the top 1000 things that will break :)