Skip to content

Commit

Permalink
Disable custom all-reduce on two Navi GPUs
Browse files Browse the repository at this point in the history
- disable custom all reduce when two Navi GPUs are used
  • Loading branch information
hyoon1 committed Nov 19, 2024
1 parent 62334b5 commit 8176798
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion vllm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
get_hf_text_config, get_pooling_config,
get_sentence_transformer_tokenizer_config, is_encoder_decoder, uses_mrope)
from vllm.utils import (GiB_bytes, cuda_device_count_stateless, get_cpu_memory,
identity, is_mi250, print_warning_once,
identity, is_mi250, is_navi, print_warning_once,
resolve_obj_by_qualname)

if TYPE_CHECKING:
Expand Down Expand Up @@ -1036,6 +1036,12 @@ def __init__(
"Disabled the custom all-reduce kernel because it is not "
"working correctly on multi AMD MI250.")

if is_navi() and self.tensor_parallel_size <= 2:
self.disable_custom_all_reduce = True
logger.info(
"Disabled the custom all-reduce kernel because it is not "
"working correctly when using two AMD Navi GPUs.")

@property
def use_ray(self) -> bool:
return self.distributed_executor_backend == "ray" or (
Expand Down

0 comments on commit 8176798

Please sign in to comment.