Rename tool #4
Merged
Rename tool #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuchen-amd I've merged some of your changes from ROCm/omnitrace#390 to here. Thank you. |
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Instead of using `$(which omnitrace)` use `$(which rocprof-sys-instrument)`, since the solo `omnitrace` binary has been deprecated.
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
The ${PROJECT_NAME} is used throughout for output paths and as a token in templates.
Using "rocprofsys" rather than "rocprof-sys" because the dash won't work for variable names (like: rocprofsys_DIR).
…ing is updated to use "rocprof-sys"
dgaliffiAMD
force-pushed
the
rename-tool
branch
from
7d3fb26 to
6c1b1c0
Compare
dgaliffiAMD
force-pushed
the
rename-tool
branch
from
282f790 to
5af11f5
Compare
Merged
ajanicijamd
previously approved these changes
Oct 8, 2024
- correct the passing regex argument. - correct path to test output.
rocprof-sys should be rocprofiler-systems
…rocprof-sys-instrument`.
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
added a commit
that referenced
this pull request
Oct 16, 2024
* Prepare for branch renaming. (#367) * Add `amd-staging` and `amd-mainline` to workflow * Update links in documentation to use amd-mainline --------- Signed-off-by: David Galiffi <[email protected]> * Update VERSION to 1.12.0 (#387) Bumping version since rocm-rel-6.3.0.1 branched. * Add rocm tag to cpack.yml (#389) * Add rocm tag to cpack.yml * Update softprops/action-gh-release to v2 * Include note about known issue with Perfetto v47.0 and above. (#391) * Reference "Known Issue" next to references of Perfetto. (#393) * And provide workaround link to Perfetto v46.0 Co-authored-by: Peter Park <[email protected]> * Rename to ROCm Systems Profiler (rocprof-sys) (#1) Rename to ROCm Systems Profiler (rocprof-sys) * Update documentation requirements (#402) (#5) * Bump rocm-docs-core to 1.8.2 * Remove empty package-ecosystem in dependabot Co-authored-by: Sam Wu <[email protected]> * Rename Omnitrace to ROCm Systems Profiler (#4) The Omnitrace program is being renamed. Full name: "ROCm Systems Profiler" Package name: "rocprofiler-systems" Binary / Library names: "rocprof-sys-*" --------- Co-authored-by: Xuan Chen <[email protected]> Signed-off-by: David Galiffi <[email protected]> * External CI: enable CI triggers (#6) --------- Signed-off-by: David Galiffi <[email protected]> Co-authored-by: Peter Park <[email protected]> Co-authored-by: Sam Wu <[email protected]> Co-authored-by: Daniel Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.