Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for proto files not being viewable in Perfetto UI #16

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD commented Oct 31, 2024

  • Ported from OMPT Target Offload Support omnitrace#411
  • Removed workaround note from documentation
  • Update workflows to added gettext to "Install Packages" step, which is now required to build Dyninst
    • Sort packages
  • Removed the pre-install of trace_processeor_shell V46, but found that the latest version, V48, cannot run on redhat 8.x, suse 15.5, and ubuntu 20.04. Install the last known good version, V47, for these workflows.

RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.

Incompatible version of GLIBC.
@dgaliffiAMD
Copy link
Collaborator Author

The latest trace_processor_shell no longer works on redhat 8.x, suse 15.5, and ubuntu 20.04.

Running the application fails with the following message:

/github/home/.local/share/perfetto/prebuilts/trace_processor_shell: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /github/home/.local/share/perfetto/prebuilts/trace_processor_shell)
/github/home/.local/share/perfetto/prebuilts/trace_processor_shell: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /github/home/.local/share/perfetto/prebuilts/trace_processor_shell)

@dgaliffiAMD dgaliffiAMD marked this pull request as ready for review November 1, 2024 02:05
@dgaliffiAMD dgaliffiAMD requested review from a team and jrmadsen as code owners November 1, 2024 02:05
Copy link
Contributor

@ajanicijamd ajanicijamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dgaliffiAMD dgaliffiAMD merged commit 21d9ab7 into ROCm:amd-staging Nov 5, 2024
33 of 37 checks passed
@dgaliffiAMD dgaliffiAMD deleted the perfetto-fix branch November 5, 2024 15:16
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 6, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD added a commit that referenced this pull request Nov 18, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
ashuverm pushed a commit that referenced this pull request Nov 22, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
ashuverm pushed a commit that referenced this pull request Nov 27, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
vamovsik pushed a commit that referenced this pull request Dec 5, 2024
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants