-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for proto files not being viewable in Perfetto UI #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from ROCm/omnitrace#411 Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
force-pushed
the
perfetto-fix
branch
from
October 31, 2024 19:39
769b6ee
to
12b5b89
Compare
RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. Incompatible version of GLIBC.
The latest Running the application fails with the following message:
|
ajanicijamd
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 6, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
This was referenced Nov 15, 2024
dgaliffiAMD
added a commit
that referenced
this pull request
Nov 18, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
ashuverm
pushed a commit
that referenced
this pull request
Nov 22, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
ashuverm
pushed a commit
that referenced
this pull request
Nov 27, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
vamovsik
pushed a commit
that referenced
this pull request
Dec 5, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <[email protected]>
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gettext
to "Install Packages" step, which is now required to build Dyninsttrace_processeor_shell
V46, but found that the latest version, V48, cannot run on redhat 8.x, suse 15.5, and ubuntu 20.04. Install the last known good version, V47, for these workflows.