Gobhardw/imp doc updates #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will only be enabled on the public repo, but present in this repo for consistency.
* Updated validation of aborted-app test to use hipExtHostAlloc now that tracing for this command is supported * Updated CHANGELOG
Skip CPU agents when fetching metrics. Only fetch metrics for GPU agents. Co-authored-by: Benjamin Welton <[email protected]>
CSV output truncates doubles to ints when it shouldn't. Derived metrics are (mostly) doubles and lose precision (or become worthless) if treated as an int. Converted these to double to match the format we return from rocprof-sdk. Co-authored-by: Benjamin Welton <[email protected]>
A fixed sized std::array is used to store counter records in rocprofiler SDK. This limit was breached in SWDEV-484742. Upping the limit to 512 to be less likely to reach this limit again.
* Fixing some accumulate metrics * Fixing some more accumulate metrics --------- Co-authored-by: Benjamin Welton <[email protected]>
* updating rocprofv3 help options * updating CHANGELOG
* Fixing installed pacakge tests in CI * Formatted rocprofv3.py with black formatter
…safety. Adding multithread tests. (#1112) * SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. * Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp Co-authored-by: Vladimir Indic <[email protected]> * Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp Co-authored-by: Vladimir Indic <[email protected]> * Adding backlog for codeobj changes * Formatting * Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp Co-authored-by: Vladimir Indic <[email protected]> * Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp Co-authored-by: Vladimir Indic <[email protected]> --------- Co-authored-by: Vladimir Indic <[email protected]>
* Fixes for metric definitions * Removing gfx8 * Update changelog * Fixing unit tests * Small fixes * Fix for write size
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h` from commit 9b2ece7
Removes ambiguity on const usage, which clang-18 complains about (preventing build with warn error).
bgopesh
requested review from
jrmadsen,
bwelton,
ammarwa,
SrirakshaNag,
vlaindic,
ApoKalipse-V,
MythreyaK,
sauverma93 and
t-tye
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details about PR
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
One sentence describing the work done.
Why were the changes made?
Explain the motivation behind the work. Provide any publicly-available historical context.
How was the outcome achieved?
Technical details behind the work. Explain any publicly-available hardware peculiarities.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.