-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SWDEV-492623: Hip Host Function to Device Symbols Mapping (#18)
* Adding changes to register and read symbols from the hip fat binary * adding json output for host_functions * added error handling * adding json tool support * Adding tests * formatting changes * Adding documentation * refactoring as per amd-staging * Adding intializers and changing macros * Fix page-migration background thread on fork (#31) * Fix page-migration background thread on fork After falling off main in the forked child, all the children try to join on on the parent's monitoring thread. This results in a deadlock. Parent is waiting for the child to exit, but the child is trying to join the parent's thread which is signaled from the parent's static destructors. Even with just one parent and child, due to copy-on-write semantics, a child signalling the background thread to join will still block (thread's updated state is not visible in the child). This fix creates background treads on fork per-child with a pthread_atfork handler, ensuring that each child has its own monitoring thread. * Formatting fixes * Detach page-migration background thread and update test timeout * Attach files with ctest * Update corr-id assert * Tweak on-fork, simplify background thread * Revert thread detach * Adding --collection-period feature in rocprofv3 to match v1/v2 parity (#9) * Adding Trace Period feature to rocprofv3 * Adding feature documentation * Update source/bin/rocprofv3.py Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing format * Moving to Collection Period and changing the input params * Format Fixes * Fixing rebasing issues * Removing atomic include from the tool * Adding more options for units, optimizing the code * Fixing rocprofv3.py * Fixing time conv & adding time controlled app * Fixing format * Changing to shared memory testing methodology * use of shmem use * Fix include headers for transpose-time-controlled.cpp * Format upload-image-to-github.py * Removing shmem and using only env var to dump timestamps from the tool * Tool Fixes + Test Config * Adding Tests * Fixing Review comments * Update trace period implementation * Update trace period tests * check between start and stop timestamps * Merge Fix * Update validate.py * Improve safety of rocprofiler_stop_context after finalization * Pass context id to collection_period_cntrl by value * Adding 20 us error margin * Ensure log level for collection-period test is not more than warning --------- Co-authored-by: Ammar ELWazir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <[email protected]> * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - move error code check macros to implementation - fix macros which check error code - use constexpr values instead of #define * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - debugging for error that cannot be locally reproduced * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - improve error handling and logging * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - tweak to non-fatal logging messages * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - cleanup of logging messages * Update host kernel symbol register data fields * Update source/lib/rocprofiler-sdk/code_object/hip/code_object.hpp --------- Co-authored-by: Madsen, Jonathan <[email protected]> Co-authored-by: Kuricheti, Mythreya <[email protected]> Co-authored-by: Elwazir, Ammar <[email protected]> Co-authored-by: Ammar ELWazir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <[email protected]>
- Loading branch information
7 people
authored
Dec 6, 2024
1 parent
61ce79c
commit 78d8f4b
Showing
25 changed files
with
899 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| // MIT License | ||
| // | ||
| // Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "lib/common/demangle.hpp" | ||
| #include "lib/common/logging.hpp" | ||
|
|
||
| #include <rocprofiler-sdk/callback_tracing.h> | ||
| #include <rocprofiler-sdk/fwd.h> | ||
| #include <rocprofiler-sdk/cxx/hash.hpp> | ||
| #include <rocprofiler-sdk/cxx/name_info.hpp> | ||
| #include <rocprofiler-sdk/cxx/operators.hpp> | ||
| #include <rocprofiler-sdk/cxx/serialization.hpp> | ||
|
|
||
| #include <cstdint> | ||
| #include <string> | ||
| #include <unordered_map> | ||
| #include <vector> | ||
|
|
||
| namespace rocprofiler | ||
| { | ||
| namespace tool | ||
| { | ||
| using rocprofiler_host_kernel_symbol_data_t = | ||
| rocprofiler_callback_tracing_code_object_host_kernel_symbol_register_data_t; | ||
|
|
||
| struct host_function_info : rocprofiler_host_kernel_symbol_data_t | ||
| { | ||
| using base_type = rocprofiler_host_kernel_symbol_data_t; | ||
|
|
||
| template <typename FuncT> | ||
| host_function_info(const base_type& _base, FuncT&& _formatter) | ||
| : base_type{_base} | ||
| , formatted_host_function_name{_formatter(CHECK_NOTNULL(_base.device_function))} | ||
| , demangled_host_function_name{common::cxx_demangle(CHECK_NOTNULL(_base.device_function))} | ||
| , truncated_host_function_name{common::truncate_name(demangled_host_function_name)} | ||
| {} | ||
|
|
||
| host_function_info(); | ||
| ~host_function_info() = default; | ||
| host_function_info(const host_function_info&) = default; | ||
| host_function_info(host_function_info&&) noexcept = default; | ||
| host_function_info& operator=(const host_function_info&) = default; | ||
| host_function_info& operator=(host_function_info&&) noexcept = default; | ||
|
|
||
| std::string formatted_host_function_name = {}; | ||
| std::string demangled_host_function_name = {}; | ||
| std::string truncated_host_function_name = {}; | ||
| }; | ||
|
|
||
| using host_function_data_vec_t = std::vector<host_function_info>; | ||
| using host_function_info_map_t = std::unordered_map<uint64_t, host_function_info>; | ||
| } // namespace tool | ||
| } // namespace rocprofiler | ||
|
|
||
| namespace cereal | ||
| { | ||
| #define SAVE_DATA_FIELD(FIELD) ar(make_nvp(#FIELD, data.FIELD)) | ||
|
|
||
| template <typename ArchiveT> | ||
| void | ||
| save(ArchiveT& ar, const ::rocprofiler::tool::host_function_info& data) | ||
| { | ||
| cereal::save( | ||
| ar, static_cast<const ::rocprofiler::tool::rocprofiler_host_kernel_symbol_data_t&>(data)); | ||
| SAVE_DATA_FIELD(formatted_host_function_name); | ||
| SAVE_DATA_FIELD(demangled_host_function_name); | ||
| SAVE_DATA_FIELD(truncated_host_function_name); | ||
| } | ||
|
|
||
| #undef SAVE_DATA_FIELD | ||
| } // namespace cereal |
Oops, something went wrong.