-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont require sphinx to be installed #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. However, there should be a check added to rocm_add_sphinx_doc
to ensure it was found before using the variable.
CMake should already error when the variable is set to not found. Either way, how would we write such an error? |
It's not directly related to this change, but I noticed a typo in the existing code where the option is named |
CMake won't emit an error. The error will occur at build time rather than at configuration time. Make will attempt to execute a program named I agree with you that including ROCMSphinxDoc shouldn't automatically cause sphinx to be required. However, allowing configuration to complete with a nonsense command for one of the targets doesn't seem right. I see two options:
|
We want the error to happen at build time not at configuration time.
Yea we dont want to require that. Unless a component has a CI that builds with a minimal dependencies(we dont have that), there nothing to enforce the users are adding the guard.
Yea and I think Also there would only be an error if calling |
Another idea, we could add the |
a62db2a
to
99ab7b4
Compare
Done! |
We need PR merge in https://github.com/RadeonOpenCompute/rocm-cmake/tree/release-staging/rocm-rel-6.0 branch too so that it will come to 6.0 Mainline. |
* Dont require sphinx to be installed * Dont require doxygen * Fix doxygen variable name
* Dont require sphinx to be installed * Dont require doxygen * Fix doxygen variable name
This should only be required when building the documentation. There is no reason to require it when users just wants to build the component.