Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small Jenkinsfile improvements #1686

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pcf000
Copy link
Contributor

@pcf000 pcf000 commented Oct 17, 2024

  1. catchError doesn't catch timeout exceptions, but try/catch does. Use try/catch in the codecov stage. This is a precursor to using "retry" to automatically catch and retry after infrastructure issues.
  2. check-rocmlir-build-only with profiling on does make some *.profraw files. Delete them before check-rocmlir.
  3. Use df to check for enough disk space before running codecov, because it'll generate around 125 GB of *.profraw files.
  4. Abstract the bulk of the codecov shell script into a function.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (82378ac) to head (2a50233).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1686      +/-   ##
===========================================
- Coverage    78.00%   77.99%   -0.02%     
===========================================
  Files           98       98              
  Lines        26498    26498              
  Branches      3809     3809              
===========================================
- Hits         20671    20668       -3     
+ Misses        4311     4292      -19     
- Partials      1516     1538      +22     
Flag Coverage Δ
mfma 77.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@krzysz00 krzysz00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants