Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tolerance and doc comments #98

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

tolerance and doc comments #98

wants to merge 1 commit into from
+13 −9

Conversation

TorreZuk
Copy link
Collaborator

  • same sum reduction as f16
  • left in some doc comments

@TorreZuk TorreZuk force-pushed the bf16-reduce-tolerance-req branch 2 times, most recently from a7f5180 to 8b51f2c Compare July 26, 2024 20:45
daineAMD
daineAMD approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@daineAMD daineAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't vouch for groovy changes but looks like the job is running fine; everything else looks good.

@TorreZuk TorreZuk force-pushed the bf16-reduce-tolerance-req branch from bce308b to 3963a01 Compare August 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daineAMD daineAMD daineAMD approved these changes

@amcamd amcamd Awaiting requested review from amcamd amcamd is a code owner

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TorreZuk @daineAMD