[FORMAT] Add .clang-format for C++ code #1404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nileshnegi
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd and
haripriya-amd
as code owners
nileshnegi
force-pushed
the
fix/add-clang-format
branch
from
4ce9d58 to
3604def
Compare
mustafabar
reviewed
Nov 27, 2024
.clang-format
Outdated
|
|
||
| AttributeMacros: ['__host__', '__device__', '__global__', '__forceinline__', '__shared__', '__launch_bounds__'] | ||
| # Trick clang into thinking that our C-style attributes are C++-style attributes | ||
| Macros: |
There was a problem hiding this comment.
this fails on Ubuntu clang-format version 14.0.0-1ubuntu1.1 (try one of the banff nodes). It complains about the Macros word usage
Signed-off-by: nileshnegi <[email protected]>
nileshnegi
force-pushed
the
fix/add-clang-format
branch
from
3604def to
b3ca052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Work item:
#1340
What were the changes?
Add a
.clang-formatfile for formatting C++ codeApproval Checklist
Do not approve until these items are satisfied.