[ROCm] torch.sum optimization by increasing min_values_per_thread #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to pytorch#135397 AMD gpus perform better with fewer thread blocks So increase the min_values_per_thread as well Co-author: https://github.com/carlobertolli
jerrymannil
requested review from
pruthvistony,
carlobertolli and
hongxiayang
pruthvistony
approved these changes
Sep 13, 2024
jithunnair-amd
pushed a commit
that referenced
this pull request
Oct 23, 2024
) Follow-up to pytorch#135397. AMD gpus perform better with fewer thread blocks. So increase the min_values_per_thread as well. This helped improved [CvT](https://github.com/facebookresearch/FAMBench/tree/main/benchmarks/cvt) benchmark performance on MI300X Co-author: @carlobertolli (cherry picked from commit c1b6f60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to pytorch#135397.
AMD gpus perform better with fewer thread blocks.
So increase the min_values_per_thread as well.
This helped improved CvT benchmark performance on MI300X
Co-author: @carlobertolli