Optional perfetto annotations #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- C API function print with warning colors - split region/trace start/stop functions into regions.cpp file
jrmadsen
added
perfetto
- moving perfetto::EventContext was causing errors
jrmadsen
added a commit
to jrmadsen/omnitrace
that referenced
this pull request
Feb 2, 2023
* Misc tweaks - C API function print with warning colors - split region/trace start/stop functions into regions.cpp file * Config option for disabling perfetto annotations * Missing checks in roctracer.cpp and sampling.cpp * Verbose makefile in CI * run-ci uses -VV * Fix gcc-7 maybe-uninitialized warning * Fix push/pop perfetto - moving perfetto::EventContext was causing errors
jrmadsen
added a commit
to jrmadsen/omnitrace
that referenced
this pull request
Feb 2, 2023
* Misc tweaks - C API function print with warning colors - split region/trace start/stop functions into regions.cpp file * Config option for disabling perfetto annotations * Missing checks in roctracer.cpp and sampling.cpp * Verbose makefile in CI * run-ci uses -VV * Fix gcc-7 maybe-uninitialized warning * Fix push/pop perfetto - moving perfetto::EventContext was causing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMNITRACE_PERFETTO_ANNOTATIONSwhich when set toOFFwill suppress the addition of debug annotations