Remove Unused GTest Dependency from Benchmark #558
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucbruni-amd
requested review from
ntrost57,
YvanMokwinski and
jsandham
as code owners
| @@ -9,6 +9,10 @@ Documentation for hipSPARSE is available at | |||
|
|
|||
| * Added `azurelinux` OS name for correcting gfortran dependency | |||
|
|
|||
| ### Optimized | |||
|
|
|||
| * Removed unused `GTest` dependency from benchmark | |||
There was a problem hiding this comment.
Is benchmark a series of tests or a suite? Should it be capitalized or in code ticks?
There was a problem hiding this comment.
Will allow other reviewers to clarify this as I am not certain on appropriate style.
There was a problem hiding this comment.
The benchmark here is an executable (specifically named hipsparse-bench) which allows performance timing of the hipsparse routines.
jsandham
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit: @AngryLoki