-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.4 version fix and mergeback 6.3 hotfixes #431
6.4 version fix and mergeback 6.3 hotfixes #431
Conversation
An update to the TwiddleIn/Out functions from PR ROCm#377 seems to be causing a build failure in onnxruntime. This change reverts the single commit (0721c2c) that made those changes. We can re-apply the change with an appropriate fix in the future. Note: the commits in the PR were squashed, so that commit will not show up in the log.
Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments.
Co-authored-by: Stanley Tsang <[email protected]>
* edited to conform to standards * edited to conform to standards
Co-authored-by: spolifroni-amd <[email protected]>
Co-authored-by: spolifroni-amd <[email protected]>
[cherry pick 6.3] Include gfx12 and gfx1151 in default architecture list for rmake.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for 6.4 version fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good after you add back the extended tests in the changelog update. Approving now so that you don't have to wait for my approval after you make the changes.
No description provided.