Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.4 version fix and mergeback 6.3 hotfixes #431

Merged

Conversation

stanleytsang-amd
Copy link
Collaborator

No description provided.

umfranzw and others added 14 commits August 26, 2024 16:09
An update to the TwiddleIn/Out functions from PR ROCm#377 seems to be causing
a build failure in onnxruntime. This change reverts the single commit
(0721c2c) that made those changes.
We can re-apply the change with an appropriate fix in the future.
Note: the commits in the PR were squashed, so that commit will not
show up in the log.
Referencing or using code from some websites is prohibited in this repository.
This change removes an informational reference in the comments.
* edited to conform to standards

* edited to conform to standards
Co-authored-by: spolifroni-amd <[email protected]>
Co-authored-by: spolifroni-amd <[email protected]>
[cherry pick 6.3] Include gfx12 and gfx1151 in default architecture list for rmake.py
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@RobsonRLemos RobsonRLemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for 6.4 version fix.

Copy link
Contributor

@NguyenNhuDi NguyenNhuDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after you add back the extended tests in the changelog update. Approving now so that you don't have to wait for my approval after you make the changes.

@stanleytsang-amd stanleytsang-amd merged commit 8eb0a34 into ROCm:develop Nov 20, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants