-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression Tests][hipCUB] Implementation of regression subtest for emulation #425
[Regression Tests][hipCUB] Implementation of regression subtest for emulation #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to changelog need to be fixed. Might as well get ahead of these now so there's less work to do before release.
Co-authored-by: spolifroni-amd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two small gramma changes that need to be made, but otherwise it's fine. I'm approving so you don't have to wait for me once you make the changes.
Co-authored-by: spolifroni-amd <[email protected]>
Co-authored-by: spolifroni-amd <[email protected]>
…huDi/hipCUB into zenguyen/regression-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The CI test failures don't appear to be caused by this change.
The implementation of regression test for emulation in rocThrust.
This is a continuation of (#419 ), do not merge until (#419 ) is merged and closed.