Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILP64 reference library for LAPACK on Windows #917

Merged
merged 2 commits into from
Sep 27, 2024
Merged

ILP64 reference library for LAPACK on Windows #917

merged 2 commits into from
Sep 27, 2024

Conversation

daineAMD
Copy link
Contributor

Also created a ticket to get rocSOLVER into Windows hipBLAS CI since this has been overlooked for far too long and would have caught this issue.

TorreZuk
TorreZuk approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay by me. So how does Linux differ on this again?

@daineAMD
Copy link
Contributor Author

This passed my tests on Windows (had to build rocSOLVER manually as CI packages didn't work), all rocSOLVER tests passed with this change.
CI is failing because of hipblasLT CI failures, I guess I can't really remove that CI dependency, though since the rocBLAS packages we're getting will dependent on hipblasLT regardless. I'll build/run tests on linux locally and merge when passed.

@daineAMD
Copy link
Contributor Author

Local linux tests all passed. Will merge and cherry-pick into 6.3 and start with local testing there tomorrow.

@daineAMD daineAMD merged commit db58bab into ROCm:develop Sep 27, 2024
11 of 21 checks passed
@daineAMD daineAMD deleted the ref-ilp64 branch September 27, 2024 01:05
daineAMD added a commit to daineAMD/hipBLAS that referenced this pull request Sep 27, 2024
@daineAMD
ILP64 reference library for LAPACK on Windows (ROCm#917)
6fb313e
daineAMD added a commit that referenced this pull request Oct 2, 2024
@daineAMD
Merge pull request #923 from daineAMD/ref64-63
b95d2cd 
ILP64 reference library for LAPACK on Windows (#917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorreZuk TorreZuk TorreZuk approved these changes

@amcamd amcamd Awaiting requested review from amcamd amcamd is a code owner

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daineAMD @TorreZuk