-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for asan build with flang #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to separate the overlap this way.
So flang will be used by them but we'll linking gfortran is okay? Did someone change our build to use flang? CI is failing for other reasons so can't see.
I tested locally by changing the compiler to flang and it seemed to work. The linking is just needed for the reference library, not really sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've prepared updates that fix flang in the build infrastructure. That problem was in their configuration, not in the hipBLAS cmake code, so I recommend against adding workarounds here. (i.e., "add gfortran dep to clients for lapack when built with flang" is unnecessary.) However, the splitting of the interface to fix the no_solver build is still worth doing.
SWDEV-407304
Basically we shouldn't have a module split between two .f90 files. Disclaimer: I'm in no way a fortran expert.
Changes:
hipblas_fortran.f90
->hipblas_fortran_blas.f90
. Contains BLAS functions (for clients), doesn't have hipblas_interface module anymorehipblas_fortran_solver.f90
hipblas_fortran_no_solver_module.f90
which includeshipblas_fortran_blas.f90
and hashipblas_interface
module. Only built with --nosolver. This could be dealt with a preprocessor macro inhipblas_fortran_module.f90
instead but not exactly sure on best practices/compiler support.hipblas_fortran_module.f90
which includeshipblas_fortran_blas.f90
,hipblas_fortran_solver.f90
and hashipblas_interface
module.We should actually add support for different fortran compilers, this is just ad-hoc and seems to work, but not sure of the future of fortran here.