Fix for cuda 12 #605
Merged
Fix for cuda 12 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
amcamd,
TorreZuk,
mahmoodw,
bragadeesh,
NaveenElumalaiAMD and
rkamd
as code owners
TorreZuk
approved these changes
May 30, 2023
amcamd
approved these changes
Jun 1, 2023
daineAMD
added a commit
to daineAMD/hipBLAS
that referenced
this pull request
Jun 5, 2023
Fix for cuda 12
daineAMD
added a commit
to daineAMD/hipBLAS
that referenced
this pull request
Jun 5, 2023
Fix for cuda 12
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #603
Copied my comment from there:
Looks like including both cublas.h and cublas_v2.h is no longer allowed in cuda 12. Appears that cublasStatus was also removed after being replaced by cublasStatus_t a while back, I guess that was missed in the past.
Your changes built fine for me on both cuda 11 and cuda 12.