-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use onnx_name field instead of op_name in MIGRAPHX_THROW as it is more informative and always defined #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohaibnd
force-pushed
the
operator_names_fix2
branch
from
October 16, 2024 14:38
ad1394e
to
33ce8e9
Compare
pfultz2
approved these changes
Oct 16, 2024
sohaibnd
force-pushed
the
operator_names_fix2
branch
3 times, most recently
from
October 16, 2024 17:13
dd00731
to
ebef85d
Compare
informative and always defined
sohaibnd
force-pushed
the
operator_names_fix2
branch
from
October 16, 2024 18:08
ebef85d
to
4128a38
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3532 +/- ##
========================================
Coverage 92.17% 92.17%
========================================
Files 512 512
Lines 21391 21393 +2
========================================
+ Hits 19718 19720 +2
Misses 1673 1673 ☔ View full report in Codecov by Sentry. |
This build is OK for merge ✅ |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are onnx parse() functions which use opd.op_name in MIGRAPHX_THROW but this field is not initialized (such as in src/onnx/parse_randomnormal_ops.cpp; see issue). Adding missing definitions for op_name does not seem appropriate since op_name is used to map to operators in src/include/migraphx/op (see calls to make_op). Instead, we can replace uses of op_name in MIGRAPHX_THROW with onnx_name for onnx operators since onnx_name is always defined and is often more descriptive for the user than op_name even when the latter is defined.